CIP-1853 - HD Stake Pool Cold Keys #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refi93
force-pushed
the
pool-cold-key-hd-derivation
branch
from
30ced0f
to
550804a
Compare
CIP-1853/CIP-1853.md
Outdated
|
|
||
| Example: `m / 1853' / 1815' / 0 / 0'` | ||
|
|
||
| Here the `usecase` is currently fixed to `0`. |
There was a problem hiding this comment.
I agree in the future some use-cases may want to be soft-derived.
I'm not sure if there is any reason to have this specific use case be soft-derived instead of hard-derived though. given all child keys are hard-derived.
SebastienGllmt
approved these changes
Jan 12, 2021
dcoutts
approved these changes
Jan 12, 2021
There was a problem hiding this comment.
Looks reasonable. I think the use case field should be hardened, as discussed in the editors meeting.
For future extensions, for new sufficiently different schemes, we can simply use new values of the purpose field. This avoids complication in the use case being harded for some and non-hardened for others. Hardened is the safe default that works for the current SPO use case, and perhaps other similar future miscellaneous independent keys.
SebastienGllmt
approved these changes
Jan 26, 2021
crptmppt
approved these changes
Jan 30, 2021
KtorZ
added a commit
that referenced
this pull request
Oct 25, 2022
KtorZ
added a commit
that referenced
this pull request
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this PR to have a wider discussion and standardize how should the stake pool cold keys be deterministically derived, to e.g. allow their management on hardware wallets
Not sure if right now there are other, possibly not yet published, CIPs that are meant to have this number as a follow-up of CIP-1852, but if they don't introduce a new derivation path purpose, it IMHO makes sense to have 1853 for this CIP which does so